Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add <ExecutableDocumentEditor /> component #281

Merged
merged 8 commits into from
Feb 7, 2022
Merged

Add <ExecutableDocumentEditor /> component #281

merged 8 commits into from
Feb 7, 2022

Conversation

dimaMachina
Copy link
Collaborator

@dimaMachina dimaMachina commented Dec 10, 2021 •
edited
Loading

related #49

Screen.Recording.2021-12-10.at.21.17.43.mov

Also, this will be nice to update graphql-language-service to v4, because curly braces { and } adds automatically for selections that have subfields, see issue

@changeset-bot
Copy link

changeset-bot bot commented Dec 10, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: a36085f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@theguild/editor Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Dec 10, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

the-guild-components – ./examples/nextjs

🔍 Inspect: https://vercel.com/theguild/the-guild-components/8ij7y62XJqXHtRq5CaRsPVBr7Npb
✅ Preview: https://the-guild-components-git-add-operationseditor-c-eb2ff5-theguild.vercel.app

the-guild-components-storybook – ./

🔍 Inspect: https://vercel.com/theguild/the-guild-components-storybook/DBm5BsmQQerKsa9iprC9thgcyr6r
✅ Preview: https://the-guild-components-storybook-git-add-operatio-4fbb4a-theguild.vercel.app

@theguild-bot
Copy link

theguild-bot commented Dec 10, 2021 •
edited
Loading

The latest changes of this PR are available as alpha in npm (based on the declared changesets):

@theguild/editor@0.5.0-alpha-1592636.0

@dimaMachina dimaMachina marked this pull request as ready for review December 10, 2021 20:21
dotansimha
dotansimha approved these changes Dec 13, 2021
View reviewed changes
Copy link
Member

@dotansimha dotansimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I saw a few adjustments in the code because of the language-service package.
I think we can merge this now, and later update dependencies.

@dotansimha
Copy link
Member

@n1ru4l please take a look and try the alpha? if it working well with the envelop playground, i think we can merge 👍

@n1ru4l
Copy link
Member

n1ru4l commented Feb 3, 2022

I think we should rename this component to ExecutableDocumentEditor what do you think @B2o5T and @dotansimha ?

@dimaMachina
Copy link
Collaborator Author

I think we should rename this component to ExecutableDocumentEditor what do you think @B2o5T and @dotansimha ?

@n1ru4l it's more correct (because we can use the editor to autocomplete only fragments) but I personally prefer <OperationsEditor />, I find its name more friendly 🙂

@n1ru4l
Copy link
Member

n1ru4l commented Feb 3, 2022

@B2o5T Sure, I am fine with both. I just think the wording is more consistent with the one the GraphQL specification uses https://spec.graphql.org/June2018/#sec-Executable-Definitions

@dotansimha
Copy link
Member

I'm fine with both :)

@dimaMachina
Copy link
Collaborator Author

Ok, so I'll rename it to ExecutableDocumentEditor and merge it tomorrow 🎉👍

@dimaMachina dimaMachina changed the title Add <OperationsEditor /> component Add < ExecutableDocumentEditor /> component Feb 7, 2022
@dimaMachina dimaMachina changed the title Add < ExecutableDocumentEditor /> component Add <ExecutableDocumentEditor /> component Feb 7, 2022
@dimaMachina dimaMachina merged commit c2be92c into main Feb 7, 2022
@dimaMachina dimaMachina deleted the add-operationseditor-component branch February 7, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotansimha dotansimha dotansimha approved these changes

@n1ru4l n1ru4l n1ru4l approved these changes

Assignees

@dimaMachina dimaMachina

@n1ru4l n1ru4l

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dimaMachina @theguild-bot @dotansimha @n1ru4l